[TwigBundle] adapt TemplateDoesNotExists test to Twig 3 expectation

dpesch · dpesch · commit c2427d093bd6 · 2019-12-08T12:31:05.000+01:00
Twig3 FilesystemLoader::findTemplate() should return `string|null` instead of Twig2 `string|null|false`: see <https://github.com/twigphp/Twig/blob/3.x/src/Loader/FilesystemLoader.php#L167> Change the test to assert `null` instead of `false`.
diff --git a/src/Symfony/Bundle/TwigBundle/Tests/Loader/FilesystemLoaderTest.php b/src/Symfony/Bundle/TwigBundle/Tests/Loader/FilesystemLoaderTest.php
@@ -123,6 +123,6 @@ public function testTwigSoftErrorIfTemplateDoesNotExist()
 
         $method = new \ReflectionMethod('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader', 'findTemplate');
         $method->setAccessible(true);
-        $this->assertFalse($method->invoke($loader, 'name.format.engine', false));
+        $this->assertNull($method->invoke($loader, 'name.format.engine', false));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,6 @@ public function testTwigSoftErrorIfTemplateDoesNotExist()`
`123`	`123`
`124`	`124`	`$method = new \ReflectionMethod('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader', 'findTemplate');`
`125`	`125`	`$method->setAccessible(true);`
`126`		`- $this->assertFalse($method->invoke($loader, 'name.format.engine', false));`
	`126`	`+ $this->assertNull($method->invoke($loader, 'name.format.engine', false));`
`127`	`127`	`}`
`128`	`128`	`}`