minor #24723 [HttpFoundation] Mark new methods on Response as final (nicolas-grekas)

fabpot · fabpot · commit e839df9e750a · 2017-10-29T14:00:00.000-07:00
This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Mark new methods on Response as final | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a913f70 [HttpFoundation] Mark new methods on Response as final
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -612,6 +612,8 @@ public function setPublic()
      * @param bool $immutable enables or disables the immutable directive
      *
      * @return $this
+     *
+     * @final
      */
     public function setImmutable($immutable = true)
     {
@@ -628,6 +630,8 @@ public function setImmutable($immutable = true)
      * Returns true if the response is marked as "immutable".
      *
      * @return bool returns true if the response is marked as "immutable"; otherwise false
+     *
+     * @final
      */
     public function isImmutable()
     {

Original file line number	Diff line number	Diff line change
`@@ -612,6 +612,8 @@ public function setPublic()`
`612`	`612`	`* @param bool $immutable enables or disables the immutable directive`
`613`	`613`	`*`
`614`	`614`	`* @return $this`
	`615`	`+ *`
	`616`	`+ * @final`
`615`	`617`	`*/`
`616`	`618`	`public function setImmutable($immutable = true)`
`617`	`619`	`{`
`@@ -628,6 +630,8 @@ public function setImmutable($immutable = true)`
`628`	`630`	`* Returns true if the response is marked as "immutable".`
`629`	`631`	`*`
`630`	`632`	`* @return bool returns true if the response is marked as "immutable"; otherwise false`
	`633`	`+ *`
	`634`	`+ * @final`
`631`	`635`	`*/`
`632`	`636`	`public function isImmutable()`
`633`	`637`	`{`