8000 [HttpFoundation] Mark new methods on Response as final by nicolas-grekas · Pull Request #24723 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Mark new methods on Response as final #24723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2017
Merged

[HttpFoundation] Mark new methods on Response as final #24723

merged 1 commit into from
Oct 29, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 28, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 28, 2017
Merged
@fabpot
Copy link
Member
fabpot commented Oct 28, 2017

Why not use the final keyword instead of the annotation?

@nicolas-grekas
Copy link
Member Author
nicolas-grekas commented Oct 28, 2017 •
edited
Loading

Because I really dislike the keyword: it's technically imperative, while we only need to state intend (like the private keyword allows).

@fabpot
Copy link
Member
fabpot commented Oct 29, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit a913f70 into symfony:3.4 Oct 29, 2017
fabpot added a commit that referenced this pull request Oct 29, 2017
@fabpot
minor #24723 [HttpFoundation] Mark new methods on Response as final (…
e839df9 
…nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Mark new methods on Response as final

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a913f70 [HttpFoundation] Mark new methods on Response as final
@nicolas-grekas nicolas-grekas deleted the req-deprec branch November 4, 2017 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
HttpFoundation Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot
0