8000 minor #23958 [Lock] Fix race condition in tests between cache and loc… · symfony/symfony@c4ecb9c · GitHub
[go: up one dir, main page]

Skip to content

Commit c4ecb9c

Browse files
minor #23958 [Lock] Fix race condition in tests between cache and lock component (jderusse)
This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #23958). Discussion ---------- [Lock] Fix race condition in tests between cache and lock component | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Currently trying to fix * [x] php 5.5 in testSaveWithDifferentResources "Failed asserting that false is true" * [x] php 5.5 in testSaveWithDifferentKeysOnSameResources "The store shouldn't save the second key" Workflow: * [x] find a reproducer * [x] fix memcached tests => #23969 * [x] fix redis tests => this PR Commits ------- 26948cf Fix race condition in tests between cache and lock
2 parents e5161c3 + 26948cf commit c4ecb9c

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

src/Symfony/Component/Cache/Tests/Adapter/AbstractRedisAdapterTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public static function setupBeforeClass()
4141

4242
public static function tearDownAfterClass()
4343
{
44-
self::$redis->flushDB();
4544
self::$redis = null;
4645
}
4746
}

src/Symfony/Component/Cache/Tests/Adapter/PredisClusterAdapterTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public static function setupBeforeClass()
2121

2222
public static function tearDownAfterClass()
2323
{
24-
self::$redis->getConnection()->getConnectionByKey('foo')->executeCommand(self::$redis->createCommand('FLUSHDB'));
2524
self::$redis = null;
2625
}
2726
}

src/Symfony/Component/Cache/Tests/Simple/AbstractRedisCacheTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public static function setupBeforeClass()
4141

4242
public static function tearDownAfterClass()
4343
{
44-
self::$redis->flushDB();
4544
self::$redis = null;
4645
}
4746
}

0 commit comments

Comments
 (0)
0