10000 minor #24061 Improved how links are displayed in exception messages (… · symfony/symfony@e5161c3 · GitHub
[go: up one dir, main page]
Skip to content

Commit e5161c3

Browse files
javiereguiluzjaviereguiluz
committed
minor #24061 Improved how links are displayed in exception messages (javiereguiluz)
This PR was merged into the 3.3 branch. Discussion ---------- Improved how links are displayed in exception messages | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If the error message is long, we reduce the font size, but I forgot to do that for links. Besides, I propose to add a subtle bottom border to make links look like what they really are. ### Before ![before](https://user-images.githubusercontent.com/73419/29971763-c8e3805e-8f29-11e7-8bab-5f709f81074b.png) ### After ![after](https://user-images.githubusercontent.com/73419/29971766-ca9029b6-8f29-11e7-9ac1-70d9b82bb893.png) Commits ------- a2af9a9 Improved how links are displayed in exception messages
2 parents 4136131 + a2af9a9 commit e5161c3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

‎src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ header .container { display: flex; justify-content: space-between; }
8484
.exception-message { flex-grow: 1; }
8585
.exception-message, .exception-message a { color: #FFF; font-size: 21px; font-weight: 400; margin: 0; }
8686
.exception-message.long { font-size: 18px; }
87-
.exception-message a { text-decoration: none; }
88-
.exception-message a:hover { text-decoration: underline; }
87+
.exception-message a { border-bottom: 1px solid rgba(255, 255, 255, 0.5); font-size: inherit; text-decoration: none; }
88+
.exception-message a:hover { border-bottom-color: #ffffff; }
8989

9090
.exception-illustration { flex-basis: 111px; flex-shrink: 0; height: 66px; margin-left: 15px; opacity: .7; }
9191

‎src/Symfony/Component/Debug/ExceptionHandler.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,8 +310,8 @@ public function getStylesheet(FlattenException $exception)
310310
.exception-message { flex-grow: 1; padding: 30px 0; }
311311
.exception-message, .exception-message a { color: #FFF; font-size: 21px; font-weight: 400; margin: 0; }
312312
.exception-message.long { font-size: 18px; }
313-
.exception-message a { text-decoration: none; }
314-
.exception-message a:hover { text-decoration: underline; }
313+
.exception-message a { border-bottom: 1px solid rgba(255, 255, 255, 0.5); font-size: inherit; text-decoration: none; }
314+
.exception-message a:hover { border-bottom-color: #ffffff; }
315315
316316
.exception-illustration { flex-basis: 111px; flex-shrink: 0; height: 66px; margin-left: 15px; opacity: .7; }
317317

0 commit comments

Comments
 (0)
0