8000 minor #58951 add comment explaining why HttpClient tests are run sepa… · symfony/symfony@85419bc · GitHub
[go: up one dir, main page]
Skip to content

Commit 85419bc

Browse files
nicolas-grekasnicolas-grekas
committed
minor #58951 add comment explaining why HttpClient tests are run separately (xabbuh)
This PR was merged into the 5.4 branch. Discussion ---------- add comment explaining why HttpClient tests are run separately | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see #35115 and #58916 Commits ------- cbdb08a add comment explaining why HttpClient tests are run separately
2 parents cf20e09 + cbdb08a commit 85419bc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

‎.github/workflows/windows.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ jobs:
110110
Remove-Item -Path src\Symfony\Bridge\PhpUnit -Recurse
111111
mv src\Symfony\Component\HttpClient\phpunit.xml.dist src\Symfony\Component\HttpClient\phpunit.xml
112112
php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
113+
# HttpClient tests need to run separately, they block when run with other components' tests concurrently
113114
php phpunit src\Symfony\Component\HttpClient || ($x = 1)
114115
115116
exit $x
@@ -123,6 +124,7 @@ jobs:
123124
124125
Copy c:\php\php.ini-max c:\php\php.ini
125126
php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
127+
# HttpClient tests need to run separately, they block when run with other components' tests concurrently
126128
php phpunit src\Symfony\Component\HttpClient || ($x = 1)
127129
128130
exit $x

0 commit comments

Comments
 (0)
0