bug #36297 [Form] action allows only strings (maxhelias)

fabpot · fabpot · commit 5aeecc2dab5b · 2020-04-04T09:23:05.000+02:00
This PR was submitted for the 5.0 branch but it was merged into the 5.1-dev branch instead. Discussion ---------- [Form] action allows only strings | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ... | License | MIT | Doc PR | ... On updating an old project that had actions to null it's caused me a type-hint error. With that, we can quickly identify where the problem is Commits ------- e861500 [Form] action allows only strings
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/FormType.php b/src/Symfony/Component/Form/Extension/Core/Type/FormType.php
@@ -203,6 +203,7 @@ public function configureOptions(OptionsResolver $resolver)
         ]);
 
         $resolver->setAllowedTypes('label_attr', 'array');
+        $resolver->setAllowedTypes('action', 'string');
         $resolver->setAllowedTypes('upload_max_size_message', ['callable']);
         $resolver->setAllowedTypes('help', ['string', 'null']);
         $resolver->setAllowedTypes('help_attr', 'array');
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php
@@ -341,6 +341,12 @@ public function testAttributesException()
         $this->factory->create(static::TESTED_TYPE, null, ['attr' => '']);
     }
 
+    public function testActionCannotBeNull()
+    {
+        $this->expectException('Symfony\Component\OptionsResolver\Exception\InvalidOptionsException');
+        $this->factory->create(static::TESTED_TYPE, null, ['action' => null]);
+    }
+
     public function testNameCanBeEmptyString()
     {
         $form = $this->factory->createNamed('', static::TESTED_TYPE);

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,12 @@ public function testAttributesException()`
`341`	`341`	`$this->factory->create(static::TESTED_TYPE, null, ['attr' => '']);`
`342`	`342`	`}`
`343`	`343`
	`344`	`+ public function testActionCannotBeNull()`
	`345`	`+ {`
	`346`	`+ $this->expectException('Symfony\Component\OptionsResolver\Exception\InvalidOptionsException');`
	`347`	`+ $this->factory->create(static::TESTED_TYPE, null, ['action' => null]);`
	`348`	`+ }`
	`349`	`+`
`344`	`350`	`public function testNameCanBeEmptyString()`
`345`	`351`	`{`
`346`	`352`	`$form = $this->factory->createNamed('', static::TESTED_TYPE);`