bug #37385 [Console] Fixes question input encoding on Windows (YaFou)

chalasr · chalasr · commit 42978978691e · 2020-07-06T10:57:31.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fixes question input encoding on Windows | Q | A | ------------- | --- | Branch? | 3.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #35842, Fix #36324, Fix #37495 and Fix #37278  | License | MIT | Doc PR | no   To ask a question to a user, the [QuestionHelper](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Helper/QuestionHelper.php) use [`fgets`](https://www.php.net/manual/en/function.fgets.php). However, special characters are not supported on Windows with this function (like accents: `é`, `à`, `ö`). The solution is to set a special encoding with [`sapi_windows_cp_get`](https://www.php.net/manual/en/function.sapi-windows-cp-get). > Before ```php $stream = fopen('php://stdin', 'r'); $input = fgets($stream); echo $input; // input: "Bonjour à tous" // output: 'Bonjour \ tous" or "Bonjour tous" ``` > After ```php // Check if the function exists because it only exists on Windows if(function_exists('sapi_windows_cp_set')) { sapi_windows_cp_get(437); } $stream = fopen('php://stdin', 'r'); $input = fgets($stream); echo $input; // input: "Bonjour à tous" // output: 'Bonjour à tous" ``` *Thanks to @bnjmnfnk for the solution 😉* Commits ------- 4288df4 [Console] Fixes question input encoding on Windows
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -158,6 +158,11 @@ private function doAsk(OutputInterface $output, Question $question)
         $inputStream = $this->inputStream ?: STDIN;
         $autocomplete = $question->getAutocompleterValues();
 
+        if (\function_exists('sapi_windows_cp_set')) {
+            // Codepage used by cmd.exe on Windows to allow special characters (éàüñ).
+            sapi_windows_cp_set(1252);
+        }
+
         if (null === $autocomplete || !self::$stty || !Terminal::hasSttyAvailable()) {
             $ret = false;
             if ($question->isHidden()) {
