8000 German Umlauts in Console · Issue #35842 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

German Umlauts in Console #35842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminfunk opened this issue Feb 24, 2020 · 5 comments · Fixed by #41113
Closed

German Umlauts in Console #35842

benjaminfunk opened this issue Feb 24, 2020 · 5 comments · Fixed by #41113
Labels
Bug Console Status: Needs Review Unconfirmed

Comments

@benjaminfunk
Copy link

Symfony version(s) affected: 5.0.4

Description
German Umlauts ignored in Console Question Helper

How to reproduce

protected function execute(InputInterface $objInput, OutputInterface $objOutput)
{
	$objHelper = $this->getHelper('question');

	$objQuestion = new Question('Title: ');

	$strTitle = $objHelper->ask($objInput, $objOutput, $objQuestion);

	$objOutput->writeln($strTitle);

        return 0;
}

If i type "aaaöäübbb" in console i just get "aaa\\bbb" as outout. If i just type umlauts like "öäü" the output is empty.
@stof
Copy link
Member
stof commented Feb 24, 2020

Please provide a bit more info:

  • OS you use
  • PHP version
  • Terminal you use (maybe it is an issue with a specific terminal)
  • encoding you use in your terminal.

@stof stof added the Console label Feb 24, 2020
@benjaminfunk
Copy link
Author
  • Windows 10
  • PHP 7.4.1
  • Default Windows Command and GIT bash
  • Dont know. Where can i find/set it?

Its not limited by the output. It happens when i write file too or in my case communicate with the shopify API.

@malteschlueter
Copy link
Contributor
malteschlueter commented Mar 31, 2020 •
edited
Loading

Maybe it's a encoding problem with your os?
I tested your example code with the same input and get the correct output with umlauts.
My setup:

  • MacOS 10.15.4
  • PHP 7.4.4
  • Default Mac Terminal
  • Should be UTF-8

@arueckauer
Copy link
arueckauer commented Apr 15, 2020 •
edited
Loading

I could reproduce the this on Windows 10.0.19041.173 using cmd, PowerShell 5.1 and PowerShell 7.0. Changing the active console code page to 65001 chcp 65001 did not bring the desired outcome. Not sure yet, how to solve this.

It looks like an encoding issue of the shell. Execution on the WSL works fine.

@YaFou
Copy link
Contributor
YaFou commented Apr 15, 2020 •
edited
Loading

I opened an issue related to this issue: #36324. I think, this issue is due to the fgets function here:

$ret = fgets($inputStream, 4096);

I explained this in more detail in my comment.

This was referenced Jun 22, 2020
Closed
Merged
chalasr added a commit that referenced this issue Jul 6, 2020
@chalasr
bug #37385 [Console] Fixes question input encoding on Windows (YaFou)
4297897 
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fixes question input encoding on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35842, Fix #36324, Fix #37495 and Fix #37278 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | no <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

To ask a question to a user, the [QuestionHelper](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Helper/QuestionHelper.php) use [`fgets`](https://www.php.net/manual/en/function.fgets.php). However, special characters are not supported on Windows with this function (like accents: `é`, `à`, `ö`). The solution is to set a special encoding with [`sapi_windows_cp_get`](https://www.php.net/manual/en/function.sapi-windows-cp-get).

> Before
```php
$stream = fopen('php://stdin', 'r');
$input = fgets($stream);
echo $input;

// input: "Bonjour à tous"
// output: 'Bonjour \ tous" or "Bonjour   tous"
```

> After
```php
// Check if the function exists because it only exists on Windows
if(function_exists('sapi_windows_cp_set')) {
    sapi_windows_cp_get(437);
}

$stream = fopen('php://stdin', 'r');
$input = fgets($stream);
echo $input;

// input: "Bonjour à tous"
// output: 'Bonjour à tous"
```

*Thanks to @bnjmnfnk for the solution 😉*

Commits
-------

4288df4 [Console] Fixes question input encoding on Windows
@chalasr chalasr closed this as completed Jul 6, 2020
@orkan orkan mentioned this issue May 5, 2021
Merged
nicolas-grekas added a commit that referenced this issue May 7, 2021
@nicolas-grekas
bug #41113 [Console] Fix Windows code page support (orkan)
53e47b3 
This PR was submitted for the 5.x branch but it was squashed and merged into the 5.2 branch instead.

Discussion
----------

[Console] Fix Windows code page support

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37385, Fix #35842, Fix #36324, Fix #37495, Fix #37278
| License       | MIT

Corrects previous fixes that dealt with the mojibake problem on Windows where an OEM code page was applied to an input string and then messed with PHP.internal_encoding setting used by the script. This caused strings with different encodings to be displayed on the console output.

Commits
-------

be68682 [Console] Fix Windows code page support
@orkan orkan mentioned this issue May 13, 2021
Merged
nicolas-grekas added a commit that referenced this issue May 13, 2021
@nicolas-grekas
bug #41210 [Console] Fix Windows code page support (orkan)
49dd6ef 
This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Fix Windows code page support

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37385, Fix #35842, Fix #36324, Fix #37495, Fix #37278
| License       | MIT

Corrects mojibake problem on Windows where an OEM code page was applied to an input string and then messed with PHP.internal_encoding setting used by the script. This caused strings with different encodings to be displayed on the console output.

Commits
-------

4145278 [Console] Fix Windows code page support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Console Status: Needs Review Unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Console] Fix Windows code page support orkan/symfony < 37AB /a>
0