minor #40930 [DependencyInjection] Better exception when a configurator is not type hinted (lyrixx)

fabpot · fabpot · commit 3c7662507d64 · 2021-05-09T17:44:29.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [DependencyInjection] Better exception when a configurator is not type hinted | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This would help with such BC break: markitosgv/JWTRefreshTokenBundle#241 Commits ------- 25813e3 [DependencyInjection] Better exception when a configurator is not type hinted
diff --git a/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
@@ -102,7 +102,7 @@ private function executeCallback(callable $callback, ContainerConfigurator $cont
         foreach ($parameters as $parameter) {
             $reflectionType = $parameter->getType();
             if (!$reflectionType instanceof \ReflectionNamedType) {
-                throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s".', $parameter->getName(), $path));
+                throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s". You must typehint it (for example with "%s" or "%s").', $parameter->getName(), $path, ContainerConfigurator::class, ContainerBuilder::class));
             }
             $type = $reflectionType->getName();
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ private function executeCallback(callable $callback, ContainerConfigurator $cont`
`102`	`102`	`foreach ($parameters as $parameter) {`
`103`	`103`	`$reflectionType = $parameter->getType();`
`104`	`104`	`if (!$reflectionType instanceof \ReflectionNamedType) {`
`105`		`- throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s".', $parameter->getName(), $path));`
	`105`	`+ throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s". You must typehint it (for example with "%s" or "%s").', $parameter->getName(), $path, ContainerConfigurator::class, ContainerBuilder::class));`
`106`	`106`	`}`
`107`	`107`	`$type = $reflectionType->getName();`
`108`	`108`