[DependencyInjection] Better exception when a configurator is not type hinted

lyrixx · lyrixx · commit 25813e380470 · 2021-04-23T17:09:03.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
@@ -102,7 +102,7 @@ private function executeCallback(callable $callback, ContainerConfigurator $cont
         foreach ($parameters as $parameter) {
             $reflectionType = $parameter->getType();
             if (!$reflectionType instanceof \ReflectionNamedType) {
-                throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s".', $parameter->getName(), $path));
+                throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s". You must typehint it (for example with "%s" or "%s").', $parameter->getName(), $path, ContainerConfigurator::class, ContainerBuilder::class));
             }
             $type = $reflectionType->getName();
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ private function executeCallback(callable $callback, ContainerConfigurator $cont`
`102`	`102`	`foreach ($parameters as $parameter) {`
`103`	`103`	`$reflectionType = $parameter->getType();`
`104`	`104`	`if (!$reflectionType instanceof \ReflectionNamedType) {`
`105`		`- throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s".', $parameter->getName(), $path));`
	`105`	`+ throw new \InvalidArgumentException(sprintf('Could not resolve argument "$%s" for "%s". You must typehint it (for example with "%s" or "%s").', $parameter->getName(), $path, ContainerConfigurator::class, ContainerBuilder::class));`
`106`	`106`	`}`
`107`	`107`	`$type = $reflectionType->getName();`
`108`	`108`