bug #34599 [Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id (monteiro)

fabpot · fabpot · commit 2dd32b02e96c · 2019-11-26T06:03:13.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id | Q | A | ------------- | --- | Branch? | master for features / 4.4 or 5.0 for bug fixes  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | (no ticket created) | License | MIT  When I set the DSN: `MAILER_DSN=mandrill://KEY@default` and try to send an email: ```php $reportEmail = (new Email()) ->subject('this is a test') ->addFrom('test@test.com') ->addTo('test-2@test.com') ->text('this is just a test.'); $mailer->send($reportEmail); ``` it returns an exception: <img width="1059" alt="Captura de ecrã 2019-11-25, às 14 31 59" src="https://user-images.githubusercontent.com/74459/69549352-0a8e6480-0f91-11ea-8d6e-ecb1ecb8caa5.png"> Stacktrace: ``` ErrorException: Notice: Undefined index: _id at /Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillHttpTransport.php:64 at Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillHttpTransport->doSendHttp(object(SentMessage)) (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractHttpTransport.php:71) at Symfony\Component\Mailer\Transport\AbstractHttpTransport->doSend(object(SentMessage)) (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractTransport.php:71) at Symfony\Component\Mailer\Transport\AbstractTransport->send(object(SentMessage), object(DelayedEnvelope)) (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/Transports.php:51) at Symfony\Component\Mailer\Transport\Transports->send(object(Email), null) (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Mailer.php:41) at Symfony\Component\Mailer\Mailer->send(object(Email)) (src/Controller/MailerController.php:20) at App\Controller\MailerController->index(object(Mailer)) ``` ## The fix, how does it work: According to [documentation](https://mandrillapp.com/api/docs/messages.html), the endpoint `https://mandrillapp.com/api/1.0/messages/send-raw.json` returns an array of results in case of success: ``` [ { "email": "recipient.email@example.com", "status": "sent", "reject_reason": "hard-bounce", "_id": "abc123abc123abc123abc123abc123" } ] ``` in case of an error: ``` { "status": "error", "code": 12, "name": "Unknown_Subaccount", "message": "No subaccount exists with the id 'customer-123'" } ``` The fix just sets the right message id. Commits ------- fa3f901 mailer: mailchimp bridge is throwing undefined index _id when setting message id in mandrill http transport
diff --git a/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillHttpTransport.php b/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillHttpTransport.php
@@ -60,7 +60,7 @@ protected function doSendHttp(SentMessage $message): ResponseInterface
             throw new HttpTransportException(sprintf('Unable to send an email (code %s).', $result['code']), $response);
         }
 
-        $message->setMessageId($result['_id']);
+        $message->setMessageId($result[0]['_id']);
 
         return $response;
     }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected function doSendHttp(SentMessage $message): ResponseInterface`
`60`	`60`	`throw new HttpTransportException(sprintf('Unable to send an email (code %s).', $result['code']), $response);`
`61`	`61`	`}`
`62`	`62`
`63`		`- $message->setMessageId($result['_id']);`
	`63`	`+ $message->setMessageId($result[0]['_id']);`
`64`	`64`
`65`	`65`	`return $response;`
`66`	`66`	`}`