8000 [Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id by monteiro · Pull Request #34599 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id #34599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

[Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id #34599

merged 1 commit into from
Nov 26, 2019

Conversation

monteiro
Copy link
Contributor
Q A
Branch? master for features / 4.4 or 5.0 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets (no ticket created)
License MIT

When I set the DSN:
MAILER_DSN=mandrill://KEY@default

and try to send an email:

$reportEmail = (new Email())
            ->subject('this is a test')
            ->addFrom('test@test.com')
            ->addTo('test-2@test.com')
            ->text('this is just a test.');

$mailer->send($reportEmail);

it returns an exception:

Captura de ecrã 2019-11-25, às 14 31 59

Stacktrace:

ErrorException:
Notice: Undefined index: _id

  at /Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillHttpTransport.php:64
  at Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillHttpTransport->doSendHttp(object(SentMessage))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractHttpTransport.php:71)
  at Symfony\Component\Mailer\Transport\AbstractHttpTransport->doSend(object(SentMessage))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractTransport.php:71)
  at Symfony\Component\Mailer\Transport\AbstractTransport->send(object(SentMessage), object(DelayedEnvelope))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/Transports.php:51)
  at Symfony\Component\Mailer\Transport\Transports->send(object(Email), null)
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Mailer.php:41)
  at Symfony\Component\Mailer\Mailer->send(object(Email))
     (src/Controller/MailerController.php:20)
  at App\Controller\MailerController->index(object(Mailer))

The fix, how does it work:

According to documentation, the endpoint https://mandrillapp.com/api/1.0/messages/send-raw.json returns an array of results in case of success:

[
    {
        "email": "recipient.email@example.com",
        "status": "sent",
        "reject_reason": "hard-bounce",
        "_id": "abc123abc123abc123abc123abc123"
    }
]

in case of an error:

{
    "status": "error",
    "code": 12,
    "name": "Unknown_Subaccount",
    "message": "No subaccount exists with the id 'customer-123'"
}

The fix just sets the right message id.

@monteiro monteiro mentioned this pull request Nov 25, 2019
Closed
@monteiro monteiro changed the title mailer: mailchimp bridge is throwing undefined index _id when setting… [Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id Nov 25, 2019
@fabpot
Copy link
Member
fabpot commented Nov 26, 2019

Thank you @monteiro.

fabpot added a commit that referenced this pull request Nov 26, 2019
@fabpot
bug #34599 [Mailer][Mailchimp Bridge] Throwing undefined index _id wh…
2dd32b0 
…en setting message id (monteiro)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer][Mailchimp Bridge] Throwing undefined index _id when setting message id

| Q             | A
| ------------- | ---
| Branch?       | master for features / 4.4 or 5.0 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | (no ticket created)
| License       | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

When I set the DSN:
`MAILER_DSN=mandrill://KEY@default`

and try to send an email:

```php
$reportEmail = (new Email())
            ->subject('this is a test')
            ->addFrom('test@test.com')
            ->addTo('test-2@test.com')
            ->text('this is just a test.');

$mailer->send($reportEmail);
```

it returns an exception:

<img width="1059" alt="Captura de ecrã 2019-11-25, às 14 31 59" src="https://user-images.githubusercontent.com/74459/69549352-0a8e6480-0f91-11ea-8d6e-ecb1ecb8caa5.png">

Stacktrace:

```
ErrorException:
Notice: Undefined index: _id

  at /Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillHttpTransport.php:64
  at Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillHttpTransport->doSendHttp(object(SentMessage))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractHttpTransport.php:71)
  at Symfony\Component\Mailer\Transport\AbstractHttpTransport->doSend(object(SentMessage))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/AbstractTransport.php:71)
  at Symfony\Component\Mailer\Transport\AbstractTransport->send(object(SentMessage), object(DelayedEnvelope))
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Transport/Transports.php:51)
  at Symfony\Component\Mailer\Transport\Transports->send(object(Email), null)
     (/Users/mac/Documents/workspace/spotahome/code/opensource/symfony/src/Symfony/Component/Mailer/Mailer.php:41)
  at Symfony\Component\Mailer\Mailer->send(object(Email))
     (src/Controller/MailerController.php:20)
  at App\Controller\MailerController->index(object(Mailer))
```

## The fix, how does it work:

According to [documentation](https://mandrillapp.com/api/docs/messages.html), the endpoint `https://mandrillapp.com/api/1.0/messages/send-raw.json` returns an array of results in case of success:

```
[
    {
        "email": "recipient.email@example.com",
        "status": "sent",
        "reject_reason": "hard-bounce",
        "_id": "abc123abc123abc123abc123abc123"
    }
]
```

in case of an error:

```
{
    "status": "error",
    "code": 12,
    "name": "Unknown_Subaccount",
    "message": "No subaccount exists with the id 'customer-123'"
}
```

The fix just sets the right message id.

Commits
-------

fa3f901 mailer: mailchimp bridge is throwing undefined index _id when setting message id in mandrill http transport
@fabpot fabpot merged commit fa3f901 into symfony:4.4 Nov 26, 2019
@stof stof mentioned this pull request Nov 26, 2019
Closed
This was referenced Dec 1, 2019
Merged
Merged
@monteiro monteiro deleted the fix/mandrill-http-transport-undefined_id_4.4 branch February 29, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@monteiro @fabpot @stof @Arthurhall @carsonbot
0