[Cache] Avoid memory leak in TraceableAdapter::reset()

lyrixx · lyrixx · commit 1e6edea2cb01 · 2020-04-15T20:00:38.000+02:00
diff --git a/src/Symfony/Component/Cache/Adapter/TraceableAdapter.php b/src/Symfony/Component/Cache/Adapter/TraceableAdapter.php
@@ -191,14 +191,8 @@ public function prune()
      */
     public function reset()
     {
-        if (!$this->pool instanceof ResettableInterface) {
-            return;
-        }
-        $event = $this->start(__FUNCTION__);
-        try {
+        if ($this->pool instanceof ResettableInterface) {
             $this->pool->reset();
-        } finally {
-            $event->end = microtime(true);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -191,14 +191,8 @@ public function prune()`
`191`	`191`	`*/`
`192`	`192`	`public function reset()`
`193`	`193`	`{`
`194`		`- if (!$this->pool instanceof ResettableInterface) {`
`195`		`- return;`
`196`		`- }`
`197`		`- $event = $this->start(__FUNCTION__);`
`198`		`- try {`
	`194`	`+ if ($this->pool instanceof ResettableInterface) {`
`199`	`195`	`$this->pool->reset();`
`200`		`- } finally {`
`201`		`- $event->end = microtime(true);`
`202`	`196`	`}`
`203`	`197`	`}`
`204`	`198`