bug #36375 [Workflow] Use a strict comparison when retrieving raw marking in MarkingStore (lyrixx)

lyrixx · lyrixx · commit 932a4f86edde · 2020-04-07T15:25:13.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Workflow] Use a strict comparison when retrieving raw marking in MarkingStore | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36358 | License | MIT | Doc PR | Commits ------- aebe8ae [Workflow] Use a strict comparison when retrieving raw markin in MarkingStore
diff --git a/src/Symfony/Component/Workflow/MarkingStore/SingleStateMarkingStore.php b/src/Symfony/Component/Workflow/MarkingStore/SingleStateMarkingStore.php
@@ -44,7 +44,7 @@ public function getMarking($subject)
     {
         $placeName = $this->propertyAccessor->getValue($subject, $this->property);
 
-        if (!$placeName) {
+        if (null === $placeName) {
             return new Marking();
         }
 
diff --git a/src/Symfony/Component/Workflow/Tests/MarkingStore/SingleStateMarkingStoreTest.php b/src/Symfony/Component/Workflow/Tests/MarkingStore/SingleStateMarkingStoreTest.php
@@ -30,4 +30,17 @@ public function testGetSetMarking()
 
         $this->assertEquals($marking, $marking2);
     }
+
+    public function testAlmostEmptyPlaceName()
+    {
+        $subject = new \stdClass();
+        $subject->myMarks = 0;
+
+        $markingStore = new SingleStateMarkingStore('myMarks');
+
+        $marking = $markingStore->getMarking($subject);
+
+        $this->assertInstanceOf(Marking::class, $marking);
+        $this->assertCount(1, $marking->getPlaces());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function getMarking($subject)`
`44`	`44`	`{`
`45`	`45`	`$placeName = $this->propertyAccessor->getValue($subject, $this->property);`
`46`	`46`
`47`		`- if (!$placeName) {`
	`47`	`+ if (null === $placeName) {`
`48`	`48`	`return new Marking();`
`49`	`49`	`}`
`50`	`50`