minor #13482 Implemented check on interface implementation (jaytaph)

fabpot · fabpot · commit 1ba939f2e6a7 · 2015-03-26T13:47:28.000+01:00
This PR was squashed before being merged into the 2.7 branch (closes #13482). Discussion ---------- Implemented check on interface implementation | Q | A | ------------- | --- | Bug fix? | Yes | New feature? | No | BC breaks? | No | Deprecations? | No | Tests pass? | Yes | Fixed tickets | #13480 | License | MIT | Doc PR | Commits ------- 2a79ace Implemented check on interface implementation
diff --git a/src/Symfony/Component/Security/Core/Authentication/AuthenticationProviderManager.php b/src/Symfony/Component/Security/Core/Authentication/AuthenticationProviderManager.php
@@ -48,6 +48,12 @@ public function __construct(array $providers, $eraseCredentials = true)
             throw new \InvalidArgumentException('You must at least add one authentication provider.');
         }
 
+        foreach ($providers as $provider) {
+            if (!$provider instanceof AuthenticationProviderInterface) {
+                throw new \InvalidArgumentException(sprintf('Provider "%s" must implement the AuthenticationProviderInterface.', get_class($provider)));
+            }
+        }
+
         $this->providers = $providers;
         $this->eraseCredentials = (bool) $eraseCredentials;
     }
diff --git a/src/Symfony/Component/Security/Core/Tests/Authentication/AuthenticationProviderManagerTest.php b/src/Symfony/Component/Security/Core/Tests/Authentication/AuthenticationProviderManagerTest.php
@@ -27,6 +27,16 @@ public function testAuthenticateWithoutProviders()
         new AuthenticationProviderManager(array());
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     */
+    public function testAuthenticateWithProvidersWithIncorrectInterface()
+    {
+        new AuthenticationProviderManager(array(
+            new \stdClass(),
+        ));
+    }
+
     public function testAuthenticateWhenNoProviderSupportsToken()
     {
         $manager = new AuthenticationProviderManager(array(

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,12 @@ public function __construct(array $providers, $eraseCredentials = true)`
`48`	`48`	`throw new \InvalidArgumentException('You must at least add one authentication provider.');`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ foreach ($providers as $provider) {`
	`52`	`+ if (!$provider instanceof AuthenticationProviderInterface) {`
	`53`	`+ throw new \InvalidArgumentException(sprintf('Provider "%s" must implement the AuthenticationProviderInterface.', get_class($provider)));`
	`54`	`+ }`
	`55`	`+ }`
	`56`	`+`
`51`	`57`	`$this->providers = $providers;`
`52`	`58`	`$this->eraseCredentials = (bool) $eraseCredentials;`
`53`	`59`	`}`