8000 bug #23330 [WebProfilerBundle] Fix full sized dump hovering in toolba… · symfony/symfony@14a54a2 · GitHub
[go: up one dir, main page]

Skip to content

Commit 14a54a2

Browse files
committed
bug #23330 [WebProfilerBundle] Fix full sized dump hovering in toolbar (ogizanagi)
This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fix full sized dump hovering in toolbar | Q | A | ------------- | --- | Branch? | 2.8 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23563 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Since #22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content: ![juin-29-2017 21-09-38](https://user-images.githubusercontent.com/2211145/27705877-b25c1496-5d0f-11e7-8fff-169e080e335c.gif) Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting). As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size. Commits ------- 28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
2 parents ce12665 + 28930c5 commit 14a54a2

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -350,13 +350,12 @@
350350
100% { background: #222; }
351351
}
352352

353-
.sf-toolbar-block.sf-toolbar-block-dump {
354-
position: static;
355-
}
356-
357353
.sf-toolbar-block.sf-toolbar-block-dump .sf-toolbar-info {
358354
max-width: none;
359-
right: 0;
355+
width: 100%;
356+
position: fixed;
357+
box-sizing: border-box;
358+
left: 0;
360359
}
361360

362361
.sf-toolbar-block-dump pre.sf-dump {

0 commit comments

Comments
 (0)
0