8000 Var Dumper in dev toolbar hover problem · Issue #23563 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Var Dumper in dev toolbar hover problem #23563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelWitten-SCU opened this issue Jul 18, 2017 · 13 comments
Closed

Var Dumper in dev toolbar hover problem #23563

MichaelWitten-SCU opened this issue Jul 18, 2017 · 13 comments
Labels
Bug Status: Needs Review VarDumper WebProfilerBundle

Comments

@MichaelWitten-SCU
Copy link
MichaelWitten-SCU commented Jul 18, 2017 •
edited
Loading
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.3.5

Since updating to Symfony 3.3.4 from 3.3.3 (or could have been 3.3.2), there has been an issue with the dump hover in the dev toolbar. I have updated to 3.3.5, but the issue is still there.

What happens, is when you hover over the dump icon in the dev toolbar (the target), it flashes on and off as you move your mouse over it (as though the hover is on the path, not the entire button), and you can not move your mouse over the popup box (with the variables in it) as it disappears before you can get there (for example, to click an arrow to open an array).

NOTE: I can not be 100% sure of when this stopped (3.3.3 or 3.3.4) working, except that it worked in a default 3.3.2. This is because when I tried to download a 3.3.3 project, the default was broken! This means that since version 3.3.3, someone has modified code in the 3.3.3 project, so I can't tell if this has caused the var dumper issue in it as well. (the error with the default 3.3.3 is Attempted to call an undefined method named "getParameter" of class "AppBundle\Controller\DefaultController".)
@ro0NL
Copy link
Contributor
ro0NL commented Jul 18, 2017

Relates to #23330 i guess.

@martixy
Copy link
martixy commented Jul 18, 2017

Can confirm... exact same issue.

Also, the pop-up box spans the width of the viewport instead of being a more, uh... "properly" shaped box. :)

@ro0NL
Copy link
Contributor
ro0NL commented Jul 18, 2017

Also, the pop-up box spans the width of the viewport instead

that's intended actually ;-) #22953

@martixy
Copy link
martixy commented Jul 18, 2017

I find this odd(especially on larger resolutions like 4K), but eh... :) Blinky bug is still totally a bug tho.

@ro0NL
Copy link
Contributor
ro0NL commented Jul 18, 2017

Dunno.. large dumps are nice imo. Note the result is a compromise, i believe, after issues with being too small. CSS min-width something.. dont go there :)

@ogizanagi
Copy link
Contributor

@martixy , @MichaelWitten-SCU : Could you confirm #23330 fixes the issue as expected?

@jmonday
Copy link
jmonday commented Jul 18, 2017

I can confirm that this is an issue on 2.8.25 as well. Hovering over the target icon causes the full width panel to flash on and off. I'm unable to hover over the panel itself.

@martixy
Copy link
martixy commented Jul 18, 2017

@ogizanagi
It does on Sy 3.3.5.

@MichaelWitten-SCU
Copy link
Author

@ogizanagi
I still have the issue after updating a current project to 3.3.5. I can try install a new project and see if it's fixed on a fresh install.

@ogizanagi
Copy link
Contributor
ogizanagi commented Jul 18, 2017 •
edited
Loading

@MichaelWitten-SCU : #23330 is not merged yet, so it's normal you still get the issue with 3.3.5.
Just try on one of your existing projects by applying this patch: https://patch-diff.githubusercontent.com/raw/symfony/symfony/pull/23330.patch

@MichaelWitten-SCU
Copy link
Author

@ogizanagi no worries, I will be at work in less than 2hrs and will do that then.

@MichaelWitten-SCU
Copy link
Author

@ogizanagi, I can confirm that this works and I can not see any other side effects etc.

@ogizanagi ogizanagi mentioned this issue Jul 19, 2017
Merged
javiereguiluz added a commit that referenced this issue Jul 19, 2017
@javiereguiluz
bug #23330 [WebProfilerBundle] Fix full sized dump hovering in toolba…
14a54a2 
…r (ogizanagi)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix full sized dump hovering in toolbar

| Q             | A
| ------------- | ---
| Branch?       | 2.8 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #23563 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Since #22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content:

![juin-29-2017 21-09-38](https://user-images.githubusercontent.com/2211145/27705877-b25c1496-5d0f-11e7-8fff-169e080e335c.gif)

Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting).

As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size.

Commits
-------

28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
@ogizanagi
Copy link
Contributor

#23330 is now merged, so this issue should be fixed in the next releases. Thanks for all the feedbacks.

ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@javiereguiluz
bug symfony#23330 [WebProfilerBundle] Fix full sized dump hovering in…
7b57b9e 
… toolbar (ogizanagi)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix full sized dump hovering in toolbar

| Q             | A
| ------------- | ---
| Branch?       | 2.8 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | symfony#23563 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Since symfony#22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content:

![juin-29-2017 21-09-38](https://user-images.githubusercontent.com/2211145/27705877-b25c1496-5d0f-11e7-8fff-169e080e335c.gif)

Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting).

As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size.

Commits
-------

28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review VarDumper WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@javiereguiluz @jmonday @ro0NL @ogizanagi @martixy @carsonbot @MichaelWitten-SCU
0