feature #51800 [DoctrineBridge] Pass Request to EntityValueResolver's expression (HypeMC)

fabpot · fabpot · commit 0c8cb7e8f2f9 · 2023-10-05T08:14:32.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge] Pass `Request` to `EntityValueResolver`'s expression | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #51694 | License | MIT Passes the `Request` object to `EntityValueResolver`'s expression. Commits ------- 1d53fe8 [DoctrineBridge] Pass `Request` to `EntityValueResolver`'s expression
diff --git a/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php b/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php
@@ -199,7 +199,10 @@ private function findViaExpression(ObjectManager $manager, Request $request, Map
         }
 
         $repository = $manager->getRepository($options->class);
-        $variables = array_merge($request->attributes->all(), ['repository' => $repository]);
+        $variables = array_merge($request->attributes->all(), [
+            'repository' => $repository,
+            'request' => $request,
+        ]);
 
         try {
             return $this->expressionLanguage->evaluate($options->expr, $variables);
diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md
@@ -8,6 +8,7 @@ CHANGELOG
  * Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder`
  * Deprecate `DoctrineDataCollector::addLogger()`, use a `DebugDataHolder` instead
  * Deprecate `ContainerAwareLoader`, use dependency injection in your fixtures instead
+ * Always pass the `Request` object to `EntityValueResolver`'s expression
 
 6.3
 ---
diff --git a/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php b/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php
@@ -334,6 +334,7 @@ public function testExpressionMapsToArgument()
             ->method('evaluate')
             ->with('repository.findOneByCustomMethod(id)', [
                 'repository' => $repository,
+                'request' => $request,
                 'id' => 5,
             ])
             ->willReturn($object = new \stdClass());
