8000 [DoctrineBridge] Pass `Request` to `EntityValueResolver`'s expression · symfony/symfony@1d53fe8 · GitHub
[go: up one dir, main page]

Skip to content

Commit 1d53fe8

Browse files
committed
[DoctrineBridge] Pass Request to EntityValueResolver's expression
1 parent 3850658 commit 1d53fe8

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,10 @@ private function findViaExpression(ObjectManager $manager, Request $request, Map
199199
}
200200

201201
$repository = $manager->getRepository($options->class);
202-
$variables = array_merge($request->attributes->all(), ['repository' => $repository]);
202+
$variables = array_merge($request->attributes->all(), [
203+
'repository' => $repository,
204+
'request' => $request,
205+
]);
203206

204207
try {
205208
return $this->expressionLanguage->evaluate($options->expr, $variables);

src/Symfony/Bridge/Doctrine/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ CHANGELOG
88
* Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder`
99
* Deprecate `DoctrineDataCollector::addLogger()`, use a `DebugDataHolder` instead
1010
* Deprecate `ContainerAwareLoader`, use dependency injection in your fixtures instead
11+
* Always pass the `Request` object to `EntityValueResolver`'s expression
1112

1213
6.3
1314
---

src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,7 @@ public function testExpressionMapsToArgument()
334334
->method('evaluate')
335335
->with('repository.findOneByCustomMethod(id)', [
336336
'repository' => $repository,
337+
'request' => $request,
337338
'id' => 5,
338339
])
339340
->willReturn($object = new \stdClass());

0 commit comments

Comments
 (0)
0