minor #59394 Update old Appveyor skip conditions (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 09c925b0ef62 · 2025-01-07T12:06:26.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- Update old Appveyor skip conditions | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Appveyor isn't used anymore in this codebase, still these tests are transient and the condition should be updated. Commits ------- ccb26a1 Update old Appveyor skip conditions
diff --git a/src/Symfony/Component/VarDumper/Tests/Dumper/ServerDumperTest.php b/src/Symfony/Component/VarDumper/Tests/Dumper/ServerDumperTest.php
@@ -39,8 +39,8 @@ public function testDumpForwardsToWrappedDumperWhenServerIsUnavailable()
 
     public function testDump()
     {
-        if ('True' === getenv('APPVEYOR')) {
-            $this->markTestSkipped('Skip transient test on AppVeyor');
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Skip transient test on Windows');
         }
 
         $wrappedDumper = $this->createMock(DataDumperInterface::class);
diff --git a/src/Symfony/Component/VarDumper/Tests/Server/ConnectionTest.php b/src/Symfony/Component/VarDumper/Tests/Server/ConnectionTest.php
@@ -24,8 +24,8 @@ class ConnectionTest extends TestCase
 
     public function testDump()
     {
-        if ('True' === getenv('APPVEYOR')) {
-            $this->markTestSkipped('Skip transient test on AppVeyor');
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Skip transient test on Windows');
         }
 
         $cloner = new VarCloner();

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ public function testDumpForwardsToWrappedDumperWhenServerIsUnavailable()`
`39`	`39`
`40`	`40`	`public function testDump()`
`41`	`41`	`{`
`42`		`- if ('True' === getenv('APPVEYOR')) {`
`43`		`- $this->markTestSkipped('Skip transient test on AppVeyor');`
	`42`	`+ if ('\\' === \DIRECTORY_SEPARATOR) {`
	`43`	`+ $this->markTestSkipped('Skip transient test on Windows');`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`$wrappedDumper = $this->createMock(DataDumperInterface::class);`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,8 @@ class ConnectionTest extends TestCase`
`24`	`24`
`25`	`25`	`public function testDump()`
`26`	`26`	`{`
`27`		`- if ('True' === getenv('APPVEYOR')) {`
`28`		`- $this->markTestSkipped('Skip transient test on AppVeyor');`
	`27`	`+ if ('\\' === \DIRECTORY_SEPARATOR) {`
	`28`	`+ $this->markTestSkipped('Skip transient test on Windows');`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`$cloner = new VarCloner();`