Use PhpStanExtractor as default extractor #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4063c99 to
b757f19
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Oct 30, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [PropertyInfo] Add `PhpStanExtractor` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #38093 | License | MIT | Doc PR | symfony/symfony-docs#... This PR will add a PhpStanExtractor that is based on `phpstan/phpdoc-parser` library. The PhpStan library allows us to manage union types in collection key values that we don't manage today. ### Todo - [x] PhpStanExtractor - [x] Add tests for unions types - [x] Add FrameworkBundle glue (use this extractor if `phpstan/phpdoc-parser` is present) - [x] Update CHANGELOG Related PR: - symfony/serializer-pack#3 put the PhpStanExtractor as default extractor to use on the `serializer-pack` package. Commits ------- 9931c37 Add PhpStanExtractor
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Oct 30, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [PropertyInfo] Add `PhpStanExtractor` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #38093 | License | MIT | Doc PR | symfony/symfony-docs#... This PR will add a PhpStanExtractor that is based on `phpstan/phpdoc-parser` library. The PhpStan library allows us to manage union types in collection key values that we don't manage today. ### Todo - [x] PhpStanExtractor - [x] Add tests for unions types - [x] Add FrameworkBundle glue (use this extractor if `phpstan/phpdoc-parser` is present) - [x] Update CHANGELOG Related PR: - symfony/serializer-pack#3 put the PhpStanExtractor as default extractor to use on the `serializer-pack` package. Commits ------- 9931c3705d Add PhpStanExtractor
b757f19 to
8e2f5f0
Compare
|
since SF 5.4 & SF 6 are out, should be merged now ? cc @nicolas-grekas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following symfony/symfony#40457