Fix compatibility with DBAL 4.x #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2afa233 to
b872aaf
Compare
derrabus
requested changes
Oct 25, 2024
| ->expects($this->never()) | ||
| ->method('executeUpdate') | ||
| ; | ||
| } else { |
There was a problem hiding this comment.
As far as I can see in doctrine/dbal 3.9 and 3.10, both methods exist. However, executeUpdate is marked as deprecated, so it might be better to use executeStatement directly.
c6c44e2 to
60d3470
Compare
60d3470 to
f50a430
Compare
|
I had to alter the way transactions in |
|
Any progress on this? Or any support needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to Table::addForeignKeyConstraint now expects only a string for the table argument, so ensure we send table name instead of Table object.