8000 Fix PHPDoc in RequirementCollection by gnutix · Pull Request #39 · symfony/requirements-checker · GitHub
[go: up one dir, main page]
Skip to content

Fix PHPDoc in RequirementCollection #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fix PHPDoc in RequirementCollection #39

merged 1 commit into from
Oct 17, 2019

Conversation

gnutix
Copy link
Contributor
@gnutix gnutix commented Oct 16, 2019 •
edited
Loading

Prevents warnings from PHPStan like :

Parameter #2 $evaluation of method
Symfony\Requirements\RequirementCollection::addPhpConfigRequirement()
expects bool|Symfony\Requirements\callback, Closure() given.

@gnutix
Fix PHPDoc in RequirementCollection
423cc71 
Prevents warnings from PHPStan like : 

```
Parameter #2 $evaluation of method Symfony\Requirements\RequirementCollection::addPhpConfigRequirement() expects bool|Symfony\Requirements\callback, Closure() given.
```
@fabpot
Copy link
Member
fabpot commented Oct 17, 2019

Thank you @gnutix.

fabpot added a commit that referenced this pull request Oct 17, 2019
@fabpot
minor #39 Fix PHPDoc in RequirementCollection (gnutix)
1130097 
This PR was merged into the 1.1.x-dev branch.

Discussion
----------

Fix PHPDoc in RequirementCollection

Prevents warnings from PHPStan like :

```
Parameter #2 $evaluation of method
Symfony\Requirements\RequirementCollection::addPhpConfigRequirement()
expects bool|Symfony\Requirements\callback, Closure() given.
```

Commits
-------

423cc71 Fix PHPDoc in RequirementCollection
@fabpot fabpot merged commit 423cc71 into symfony:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnutix @fabpot
0