8000 Update recipes for Jane v6.0 by Korbeil · Pull Request #888 · symfony/recipes-contrib · GitHub
[go: up one dir, main page]
Skip to content

Update recipes for Jane v6.0 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jun 2, 2020
Merged

Update recipes for Jane v6.0 #888

1 commit merged into from
Jun 2, 2020

Conversation

Korbeil
Copy link
Contributor
@Korbeil Korbeil commented Mar 26, 2020
Q A
License MIT

Update Jane recipes for v6.0

ghost
ghost suggested changes Mar 26, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost approved these changes Mar 26, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

8000
ghost
ghost approved these changes Mar 26, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Apr 1, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm requested changes Apr 5, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really understand these recipes. I see that you put a bin file and some config.. This package does not seam like it has anything to do with the project itself.

jane-php/open-api-common/6.0/config/packages/jane_open_api.yaml Outdated
# public: false
#
# MyApp\Library\Generated\:
# resource: '%kernel.root_dir%/generated/*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file only has comments. We dont need that.

Copy li 8000 nk
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose, as stated in https://github.com/symfony/recipes-contrib/pull/888/files#diff-86fec314f57019f4403b1f6a4e9c30d6R9 or https://github.com/symfony/recipes-contrib/pull/888/files#diff-35c3cdf07a7584253c1adce3da720b28R9, it needs to be edited. I provide this config because it's optimized for Jane

jane-php/json-schema/6.0/config/packages/jane_json_schema.yaml Outdated
# autowire: true
# autoconfigure: true
# public: false
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

ghost
ghost approved these changes Apr 8, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

welcoMattic
welcoMattic reviewed Apr 10, 2020
View reviewed changes
ghost
ghost approved these changes Apr 11, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Korbeil Korbeil force-pushed the recipe/jane-php branch from 591e68e to 2bcec37 Compare May 6, 2020 16:32
ghost
ghost approved these changes May 6, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Korbeil Korbeil force-pushed the recipe/jane-php branch from 2bcec37 to edf3542 Compare May 7, 2020 07:42
ghost
ghost approved these changes May 7, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Korbeil Korbeil force-pushed the recipe/jane-php branch from edf3542 to 9f5e009 Compare May 7, 2020 10:52
ghost
ghost approved these changes May 7, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Korbeil
Copy link
Contributor Author
Korbeil commented May 7, 2020

@Nyholm It seems the CI does not check for conflict parameter, how could I avoid theses failed tests ?

JohanLopes
JohanLopes reviewed May 7, 2020
View reviewed changes
@Korbeil Korbeil force-pushed the recipe/jane-php branch from 9f5e009 to a5f28e4 Compare May 7, 2020 14:38
ghost
ghost approved these changes May 7, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm reviewed May 31, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks alright. Just some minor things to make it a little better and to avoid adding a file with only comments.

@Korbeil Korbeil force-pushed the recipe/jane-php branch from a5f28e4 to ece0d6f Compare May 31, 2020 18:56
ghost
ghost suggested changes May 31, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Korbeil Korbeil force-pushed the recipe/jane-php branch from ece0d6f to b6b8ba2 Compare May 31, 2020 18:59
ghost
ghost approved these changes May 31, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Nyholm
Copy link
Member
Nyholm commented Jun 1, 2020

Thank you. Could you make sure at least one CI passes

@Korbeil
Copy link
Contributor Author
Korbeil commented Jun 2, 2020

The bug on CI with Symfony 5.* is caused by symfony/symfony#37058

Nyholm
Nyholm approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis on 5.1 is red because of symfony/symfony#37058

@ghost ghost merged commit 674fc83 into symfony:master Jun 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanLopes JohanLopes JohanLopes left review comments

@welcoMattic welcoMattic welcoMattic left review comments

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Korbeil @Nyholm @JohanLopes @welcoMattic
0