8000 Add the fork of phone-number-bundle recipe by Nek- · Pull Request #787 · symfony/recipes-contrib · GitHub
[go: up one dir, main page]
Skip to content

Add the fork of phone-number-bundle recipe #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 28, 2019
Merged

Add the fork of phone-number-bundle recipe #787

1 commit merged into from
Nov 28, 2019

Conversation

Nek-
Copy link
Contributor
@Nek- Nek- commented Nov 27, 2019

After lack of maintainance of the main bundle, we decided to fork the bundle, this recipe will help new users.

Q A
License MIT

ghost
ghost approved these changes Nov 27, 2019
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Taluu
Taluu suggested changes Nov 27, 2019
View reviewed changes
@Nek-
Add fork of phone bundle recipe
4e254a5 
After lack of maintainance of the main bundle, we decided to fork the
bundle, this recipe will help new users.
@Nek- Nek- force-pushed the feature/new-phone-number-bundle branch from 7cd7fca to 4e254a5 Compare November 27, 2019 15:57
ghost
ghost approved these changes Nov 27, 2019
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@jderusse
Copy link
Member
jderusse commented Nov 28, 2019 •
edited
Loading

Any reason for not registering this recipe for tag 1.3 (or 2.x) to allow people using libphonenumber-for-php < 8 ?

@maxhelias
Copy link
Contributor

@jderusse Good point, i think we can

Nyholm
Nyholm approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I'll merge this now and allow you to add another recipe for lower versions in a separate PR.

ghost pushed a commit that referenced this pull request Nov 28, 2019
Merge pull request #787
8e0ecb9
@ghost ghost merged commit 4e254a5 into symfony:master Nov 28, 2019
@Nek- Nek- deleted the feature/new-phone-number-bundle branch November 30, 2019 14:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taluu Taluu Taluu requested changes

@jderusse jderusse jderusse left review comments

@maxhelias maxhelias maxhelias approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nek- @jderusse @maxhelias @Taluu @Nyholm
0