8000 feat: Add recipe for Doctrine Diagram Bundle v1 by jawira · Pull Request #1795 · symfony/recipes-contrib · GitHub
[go: up one dir, main page]
Skip to content

feat: Add recipe for Doctrine Diagram Bundle v1 #1795

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

feat: Add recipe for Doctrine Diagram Bundle v1 #1795

merged 1 commit into from
May 15, 2025

Conversation

jawira
Copy link
Contributor
@jawira jawira commented May 11, 2025

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 11, 2025 19:06
@github-actions GitHub Actions
Copy link
github-actions bot commented May 11, 2025 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1795/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1795/index.json

  2. Install the package(s) related to this recipe:

    composer req symfony/flex
composer req 'jawira/doctrine-diagram-bundle:^1.0'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

jawira/doctrine-diagram-bundle

0.7 vs 1.0 
diff --git a/jawira/doctrine-diagram-bundle/0.7/config/packages/doctrine_diagram.yaml b/jawira/doctrine-diagram-bundle/1.0/config/packages/doctrine_diagram.yaml
index 31774a5e..e07af98d 100644
--- a/jawira/doctrine-diagram-bundle/0.7/config/packages/doctrine_diagram.yaml
+++ b/jawira/doctrine-diagram-bundle/1.0/config/packages/doctrine_diagram.yaml
@@ -1,5 +1,24 @@
 # https://github.com/jawira/doctrine-diagram-bundle
-doctrine_diagram:
-    size: midi
-    filename: database
-    format: svg
+when@dev:
+    doctrine_diagram:
+        er:
+            filename: '%kernel.project_dir%/er'
+            size: midi
+        class:
+            filename: '%kernel.project_dir%/class'
+            size: midi
+        convert:
+            format: svg
+            converter: auto
+
+when@test:
+    doctrine_diagram:
+        er:
+            filename: '%kernel.project_dir%/er'
+            size: midi
+        class:
+            filename: '%kernel.project_dir%/class'
+            size: midi
+        convert:
+            format: svg
+            converter: auto
diff --git a/jawira/doctrine-diagram-bundle/0.7/manifest.json b/jawira/doctrine-diagram-bundle/1.0/manifest.json
index 257ba2d8..94057888 100644
--- a/jawira/doctrine-diagram-bundle/0.7/manifest.json
+++ b/jawira/doctrine-diagram-bundle/1.0/manifest.json
@@ -1,6 +1,6 @@
 {
     "bundles": {
-        "Jawira\\DoctrineDiagramBundle\\DoctrineDiagramBundle": ["all"]
+        "Jawira\\DoctrineDiagramBundle\\DoctrineDiagramBundle": ["dev", "test"]
     },
     "copy-from-recipe": {
         "config/": "%CONFIG_DIR%/"

@jawira
Copy link
Contributor Author
jawira commented May 11, 2025

Hello! The Doctrine Diagram Bundle v1 is not ready yet, so I'm marking this PR as a draft for now.

@jawira jawira marked this pull request as draft May 11, 2025 19:31
auto-merge was automatically disabled May 11, 2025 19:31

Pull request was converted to draft

@jawira jawira marked this pull request as ready for review May 12, 2025 21:35
@jawira jawira force-pushed the doctrine-diagram-v1 branch from 65a28f2 to d49933b Compare May 12, 2025 21:36
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 12, 2025 21:36
auto-merge was automatically disabled May 12, 2025 21:39

Head branch was pushed to by a user without write access

@jawira jawira force-pushed the doctrine-diagram-v1 branch from d49933b to 4b0217c Compare May 12, 2025 21:39
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 12, 2025 21:39
@jawira
Copy link
Contributor Author
jawira commented May 12, 2025

Hi. DoctrineDiagramBundle v1 was released.
GA is failing because it can't install the bundle in PHP 7.4, however the minimum required version by this bundle is ^8.1.

@symfony-recipes-bot symfony-recipes-bot merged commit d89a056 into symfony:main May 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawira @diimpp @symfony-recipes-bot
0