Allow .php config files (and others) to be loaded in the Kernel by default. #913
Conversation
|
I think we're not ready to make this move. Yaml is still the best format in 👎 on my side sorry. |
|
Thank you. $container->import('../config/{packages}/*.yaml');
// Uncomment this line to allow configuration with PHP files
// $container->import('../config/{packages}/*.php'); |
We try to keep recipes as clean as possible, that's why I'd prefer not... |
|
Hm. Okey. @dreadnip. I'll close this PR now. Could you open a similar PR in 5-6 months? I think we are more mature with the idea then. It is also a few issues we should take care of before fully embracing php config. I appreciate that you took your time to make this PR. Thank you. |
I'd like to suggest a partial rollback of this PR by @nicolas-grekas. Since both Symfony internally and the community are moving in the direction of PHP configs, I feel like it'd be nice to allow these out-of-the-box when using the framework bundle.
Right now if you switch to PHP config files, either manually or by using a tool, you end up with a broken Symfony app. If we import .php config files in the default kernel, this would work straight away.
My apologies if this PR is misplaced in any way, it is my first attempt to contribute and I couldn't quite figure out which repo I had to submit the PR to.