8000 Add recipe for SpotHit Notifier bridge by JamesHemery · Pull Request #881 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Add recipe for SpotHit Notifier bridge #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Feb 15, 2021
Merged

Add recipe for SpotHit Notifier bridge #881

4 commits merged into from
Feb 15, 2021

Conversation

JamesHemery
Copy link
Contributor
Q A
License MIT
Doc issue/PR symfony/symfony-docs#14869

ghost
ghost suggested changes Jan 23, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@JamesHemery JamesHemery mentioned this pull request Jan 23, 2021
Merged
OskarStark
OskarStark requested changes Jan 24, 2021
View reviewed changes
@JamesHemery @OskarStark
[Notifier][SpotHit] Update manifest
b9282aa 
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
ghost
ghost suggested changes Jan 24, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this commen 8000 t

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

OskarStark
OskarStark reviewed Feb 2, 2021
View reviewed changes
ghost
ghost suggested changes Feb 2, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

OskarStark added a commit to symfony/symfony that referenced this pull request Feb 3, 2021
@OskarStark
feature #39948 [Notifier] [SpotHit] Add the bridge (JamesHemery)
3eb8a42 
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [SpotHit] Add the bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14869
| Recipe PR        | symfony/recipes#881

@OskarStark Bridge added :)

Commits
-------

afcca88 [Notifier] [SpotHit] Add the bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Feb 3, 2021
@OskarStark
feature #39948 [Notifier] [SpotHit] Add the bridge (JamesHemery)
e741e26 
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [SpotHit] Add the bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14869
| Recipe PR        | symfony/recipes#881

@OskarStark Bridge added :)

Commits
-------

afcca88af2 [Notifier] [SpotHit] Add the bridge
symfony-splitter pushed a commit to symfony/notifier that referenced this pull request Feb 3, 2021
@OskarStark
feature #39948 [Notifier] [SpotHit] Add the bridge (JamesHemery)
c2ab1f2 
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [SpotHit] Add the bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14869
| Recipe PR        | symfony/recipes#881

@OskarStark Bridge added :)

Commits
-------

afcca88af2 [Notifier] [SpotHit] Add the bridge
ghost
ghost suggested changes Feb 14, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Feb 14, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Feb 14, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@fabpot
Copy link
Member
fabpot commented Feb 14, 2021

Can you rename the directory to spot-hit-notifier?

ghost
ghost approved these changes Feb 14, 2021
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 50d4ec5 into symfony:master Feb 15, 2021
@JamesHemery JamesHemery deleted the spothit-notifier branch February 15, 2021 08:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesHemery @fabpot @OskarStark
0