8000 Exclude src/preload.php from service discovery by nicolas-grekas · Pull Request #818 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Exclude src/preload.php from service discovery #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Exclude src/preload.php from service discovery #818

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member
Q A
License MIT
Doc issue/PR -

As spotted in symfony/symfony#38123

ghost
ghost approved these changes Sep 10, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member Author

(give me a few minutes before adding a second vote, I want to check something)

fabpot
fabpot requested changes Sep 10, 2020
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not a good solution (as people upgrading to latest 4.4/5.1 won't get this change).

8000

@nicolas-grekas nicolas-grekas deleted the preload-excl branch September 10, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @chalasr
0