[FrameworkBundle] Use an array for exclude directive #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great change for DX because it simpler to add path than editing the glob 👍 Thanks! |
|
this is not supported in 4.2 IIRC. It was added in a later version. |
ogizanagi
approved these changes
Jul 16, 2020
|
@stof I think it is: symfony/symfony#27075 is part of 4.2 |
8000
|
Oh indeed. |
|
👍 I like this. Thanks Grég. I don't approve it because then it will have 2 official approves and it will be merged automatically. I'd prefer if Nico and/or Fabien approve this change. Thanks! |
fabpot
approved these changes
Jul 22, 2020
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 22, 2022
…lexander-schranz) This PR was merged into the 4.4 branch. Discussion ---------- Update service documentation with udpate recipe files The asterisk was removed some time ago as not required and the Tests and Migrations are also were also removed from exclude. See discussion about asterisk here: symfony/recipes#802 (comment) Commits ------- b89847e Update service documentation with udpate recipe files
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, this notation is easier to understand. More over it scales really
better. Finally this notation is not documented on the following
page