8000 Update conf to log deprecations in a dedicated channel by nicolas-grekas · Pull Request #775 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Update conf to log deprecations in a dedicated channel #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
May 29, 2020
Merged

Update conf to log deprecations in a dedicated channel #775

1 commit merged into from
May 29, 2020

Conversation

nicolas-grekas
Copy link
Member
Q A
License MIT
Doc issue/PR symfony/symfony-docs#13642

Follows symfony/symfony#36621

ghost
ghost approved these changes May 28, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas nicolas-grekas mentioned this pull request May 28, 2020
Closed
Nyholm
Nyholm reviewed May 28, 2020
View reviewed changes
l-vo
l-vo approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor
@l-vo l-vo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

ghost
ghost approved these changes May 28, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes May 28, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes May 29, 2020
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit da2347c into symfony:master May 29, 2020
@nicolas-grekas nicolas-grekas deleted the deprec branch May 29, 2020 21:27
glensc added a commit to glensc/eventum that referenced this pull request Jun 27, 2020
@glensc
Split deprecations logger to separate config
4eeb227 
Config provided by flex

- symfony/recipes@daca38d
- symfony/recipes#775
glensc added a commit to glensc/eventum that referenced this pull request Jun 27, 2020
@glensc
Configure (and enable) deprecations logger in separate config
42000c6 
Similar to one provided by flex for 5.1

- symfony/recipes@daca38d
- symfony/recipes#775
@GPHemsley
Copy link

What effect does this have on Symfony versions prior to 5.1, such as LTS 4.4?

@l-vo
Copy link
Contributor
l-vo commented Sep 22, 2020

There is no effect for versions before 5.1. If you enable the configuration to log deprecation in a separate file for these versions, the file should stay empty since nothing is sent to the deprecation channel.

@GPHemsley
Copy link

There is no effect for versions before 5.1. If you enable the configuration to log deprecation in a separate file for these versions, the file should stay empty since nothing is sent to the deprecation channel.

That makes sense for the new (commented out) code, but what about the code that was removed as part of this PR? If I want to log deprecations in 4.4, is it advised that I keep that intact?

@l-vo
Copy link
Contributor
l-vo commented Sep 23, 2020

Yes, you can keep the old code, it will work in 4.4 and also in next versions. Anyway the recipe update should not be proposed in 4.4.

@GPHemsley
Copy link
GPHemsley commented Sep 23, 2020 •
edited
Loading

Yes, you can keep the old code, it will work in 4.4 and also in next versions.

OK, thanks.

Anyway the recipe update should not be proposed in 4.4.

Does that mean there's a bug? Because it is being proposed in 4.4. (My dependency is defined as "symfony/monolog-bundle": "^3.1".)

@l-vo
Copy link
Contributor
l-vo commented Sep 23, 2020

Oh indeed, good catch !

deprecation_filter config should not be removed, I think it's related to the hesitation about where to put the recipe.

Do you want to create a PR for fixing it ? I would do it otherwise.

@GPHemsley
Copy link

@l-vo It's all yours.

@l-vo l-vo mentioned this pull request Oct 7, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@Nyholm Nyholm Nyholm approved these changes

@l-vo l-vo l-vo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @GPHemsley @l-vo @weaverryan @Nyholm
0