Enable container.autowiring.strict_mode #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does such discussion happens on the recipes repository rather than on Symfony (where the feature needs to be developed) ? I think much less people are following discussions there. |
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Oct 24, 2017
…t from legacy autowiring (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To preserve BC, autowiring still wires things in hybrid 2.8/3.3 modes. But 2.8 mode is really a foot gun. I propose to add a new parameter in SF3.4, to opt-out of this 2.8 mode, and enable this strict mode for all new projects. WDYT? (see symfony/recipes#221 for corresponding change on Flex recipe) Commits ------- a4a0ae2 [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 24, 2017
…t from legacy autowiring (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To preserve BC, autowiring still wires things in hybrid 2.8/3.3 modes. But 2.8 mode is really a foot gun. I propose to add a new parameter in SF3.4, to opt-out of this 2.8 mode, and enable this strict mode for all new projects. WDYT? (see symfony/recipes#221 for corresponding change on Flex recipe) Commits ------- a4a0ae2 [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring
|
PR ready for votes, feature symfony/symfony#24671 merged |
ogizanagi
approved these changes
Oct 24, 2017
chalasr
approved these changes
Oct 24, 2017
javiereguiluz
approved these changes
Oct 24, 2017
ghost
pushed a commit
that referenced
this pull request
Oct 24, 2017
|
This should be enabled in symfony-standard 3.4 as well. |
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Nov 9, 2017
This PR was merged into the 3.4 branch. Discussion ---------- enable container.autowiring.strict_mode as pointed out by @Tobion in symfony/recipes#221 (comment) Commits ------- a6a19c5 enable container.autowiring.strict_mode
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve BC, autowiring still wires things in hybrid 2.8/3.3 modes.
But 2.8 mode is really a foot gun.
I propose to add a new parameter in SF3.4, to opt-out of this 2.8 mode, and enable this strict mode for all new projects.
WDYT?