8000 Add twig-extensions extensions as services by fabpot · Pull Request #173 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Add twig-extensions extensions as services #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2017
Merged

Add twig-extensions extensions as services #173

merged 1 commit into from
Sep 11, 2017

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Sep 10, 2017
Q A
License MIT

see symfony/symfony#22849

symfony-bot
symfony-bot previously approved these changes Sep 10, 2017
View reviewed changes
@fabpot fabpot mentioned this pull request Sep 10, 2017
Closed
@javiereguiluz
Copy link
Member

This looks a bit confusing to me. Twig extensions are a different project/repo from Twig, so if you uncomment this, you'll see an error (unless you install extensions). And having this config if you don't use extensions, looks strange.

@fabpot
Copy link
Member Author
fabpot commented Sep 11, 2017

@javiereguiluz You're right. Perhaps we need to create a twig_extensions.yml file that is installed only when twig/extensions is installed. WDYT?

@fabpot fabpot force-pushed the twig-extensions branch 3 times, most recently from cf93bc2 to 51d19e6 Compare September 11, 2017 14:16
symfony-bot
symfony-bot suggested changes Sep 11, 2017
View reviewed changes
twig/extensions/1.0/manifest.json Outdated
@@ -0,0 +1,6 @@
{
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

twig/extensions/1.0/manifest.json Outdated
@@ -0,0 +1,6 @@
{
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

symfony-bot
symfony-bot previously approved these changes Sep 11, 2017
View reviewed changes
@fabpot
Copy link
Member Author
fabpot commented Sep 11, 2017

@javiereguiluz Does it look better?

stof
stof previously requested changes Sep 11, 2017
View reviewed changes
twig/extensions/1.0/config/packages/twig_extensions.yaml Outdated

#Twig\Extensions\ArrayExtension: ~
#Twig\Extensions\DateExtension: ~
#Twig\Extensions\I18nExtension: ~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should not be included IMO, as it conflicts with the Symfony TranslatorExtension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

twig/extensions/1.0/config/packages/twig_extensions.yaml
@@ -0,0 +1,10 @@
services:
_defaults:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also have public: false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

symfony-bot
symfony-bot previously approved these changes Sep 11, 2017
View reviewed changes
@symfony-bot symfony-bot merged commit 9711c5d into master Sep 11, 2017
8654
@xabbuh xabbuh deleted the twig-extensions branch September 11, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@symfony-bot symfony-bot symfony-bot approved these changes

@stof stof stof left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @javiereguiluz @nicolas-grekas @stof @symfony-bot
0