8000 [symfony/property-info] Add `with_constructor_extractor` to silence deprecation by HypeMC · Pull Request #1419 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

[symfony/property-info] Add with_constructor_extractor to silence deprecation #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[symfony/property-info] Add with_constructor_extractor to silence deprecation #1419

merged 1 commit into from
May 28, 2025

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented May 25, 2025
Q A
License MIT
Doc issue/PR symfony/symfony-docs#20752

To silence the deprecation added in symfony/symfony#50334

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 25, 2025 21:51
@github-actions GitHub Actions
Copy link
github-actions bot commented May 25, 2025 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY 8000 _ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1419/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1419/index.json

  2. Install the package(s) related to this recipe:

    composer req symfony/flex
composer req 'symfony/property-info:^7.3'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

mtarld
mtarld previously approved these changes May 26, 2025
View reviewed changes
@rosier
Copy link
Contributor
rosier commented May 26, 2025

I think this will break the composer create-project symfony/skeleton and symfony new my-project commands.

If I'm not mistaken this will lead to a 'Unrecognized option' error as 'symfony/property-info' isn't part of 'symfony/skeleton'.

@HypeMC HypeMC force-pushed the property-info-constructor-extractor branch from eb0d56f to 2e9d68f Compare May 26, 2025 20:06
@HypeMC HypeMC changed the title [symfony/framework-bundle] Add with_constructor_extractor to silence deprecation [symfony/property-info] Add with_constructor_extractor to silence deprecation May 26, 2025
@HypeMC
Copy link
Member Author
HypeMC commented May 26, 2025

@rosier Good point, fixed

@symfony-recipes-bot symfony-recipes-bot merged commit be40a28 into symfony:main May 28, 2025
1 of 2 checks passed
@HypeMC HypeMC deleted the property-info-constructor-extractor branch May 28, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@rosier rosier rosier approved these changes

@OskarStark OskarStark OskarStark approved these changes

@mtarld mtarld mtarld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HypeMC @rosier @fabpot @OskarStark @mtarld @symfony-recipes-bot
0