Fixed broken build #45
8000
Jump to bottom
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we bump to v2 then? |
|
Yes, And introduce PSR17 factories. The PSR17 does not support php5. |
This was referenced Aug 4, 2018
|
I just had a look at #43. That implementation makes it optional to use PSR 17 (HTTP factories). Then it makes no sense to drop PHP versions. This PR brings no changes nor drops any functionality. |
|
Wohoo build passes on Travis! |
fabpot
approved these changes
Aug 6, 2018
|
Ping @nicolas-grekas |
.travis.yml
Outdated
| # Test LTS versions. This makes sure we do not use Symfony packages with version greater | ||
| # than 2 or 3 respectively. | ||
| - php: 7.2 | ||
| env: DEPENDENCIES="symfony/lts:^2 symfony/force-lowest:^2.8 zendframework/zend-diactoros:^1.4.1" |
There was a problem hiding this comment.
symfony/force-lowest should reference an exact version to work correctly:
symfony/force-lowest:=2.8 or symfony/force-lowest:v2.8
|
Travis is happy again |
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Aug 8, 2018
This PR was squashed before being merged into the 1.0-dev branch (closes #45). Discussion ---------- Fixed broken build This PR updates travis.yml to adapt to our best practices: https://symfony.com/doc/current/bundles/best_practices.html It update our dependencies (dropping sf2.8 and unsupported symfony versions) It also remove use of deprecated code. Commits ------- 8780dd3 Fixed broken build
|
Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates travis.yml to adapt to our best practices: https://symfony.com/doc/current/bundles/best_practices.html
It update our dependencies (dropping sf2.8 and unsupported symfony versions)
It also remove use of deprecated code.