Add polyfill for Intl\MessageFormatter #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebe
reviewed
Sep 21, 2018
| * POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| * Originally forked from | ||
| * https://github.com/yiisoft/yii2/blob/master/framework/i18n/MessageFormatter.php |
There was a problem hiding this comment.
you should probably make this a permalink pointing to a tag instead of master to make sure the link does not get broken later.
https://github.com/yiisoft/yii2/blob/2.0.15/framework/i18n/MessageFormatter.php
There was a problem hiding this comment.
Good idea, done, thanks!
cebe
reviewed
Sep 21, 2018
| * POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| * Originally forked from | ||
| * https://github.com/yiisoft/yii2/blob/master/tests/framework/i18n/FallbackMessageFormatterTest.php |
There was a problem hiding this comment.
samdark
approved these changes
Sep 21, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 22, 2018
This PR was merged into the 1.9-dev branch. Discussion ---------- Add polyfill for Intl\MessageFormatter This is a fork of Yii's [fallback MessageFormatter](https://github.com/yiisoft/yii2/blob/master/framework/i18n/MessageFormatter.php) implementation, ported as a polyfill of intl's MessageFormatter. I also reformatted the code to make it more in line with our practices and added some notes if we want to push the polyfill forward. The test suite compares both native and PHP variants, with similar results. Kudos to them! ping @cebe and @samdark FYI Commits ------- ed8c89d Add polyfill for Intl\MessageFormatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork of Yii's fallback MessageFormatter implementation, ported as a polyfill of intl's MessageFormatter. I also reformatted the code to make it more in line with our practices and added some notes if we want to push the polyfill forward. The test suite compares both native and PHP variants, with similar results.
Kudos to them!
ping @cebe and @samdark FYI