8000 Support PHPUnit 10 by arderyp · Pull Request #589 · symfony/panther · GitHub
[go: up one dir, main page]
Skip to content

Support PHPUnit 10 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 30, 2023
Merged

Support PHPUnit 10 #589

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4e437b9
[phpunit-10] first pass at making Panther workable with phpunit-10; t…
Mar 1, 2023
0fa6fcd
require php 8.1, because phpunit 10 requires it
Mar 1, 2023
4ca6bca
adding php-cs-fixer dependency, running fixer using default config
Mar 1, 2023
5cf344a
moving php requirement back to ^8.0 to support older versions of PHPU…
Mar 2, 2023
e7b3520
making takeScreenshotIfTestFailed compatible with PHPUnit <10 as well…
Mar 2, 2023
7124b9e
removing .idea
Mar 2, 2023
cdcd7e0
removing phpstan and php-cs-fixer from dev dependencies
Mar 2, 2023
3c0c3f6
removing phpunit dev dependency, replacing with phpunit-bridge; rever…
Mar 3, 2023
8ccc2b3
ran php-cs-fixer
Mar 3, 2023
8e07d4f
skipping test assertion when inconsistent empty html bug reveals itss…
Mar 3, 2023
e0332c4
making test workaround more explicit
Mar 3, 2023
41757c6
making inconsistent test workaround more robust
Mar 3, 2023
bf31fda
thought I removed new isGetClientStaticMethodAvailable function but I…
Mar 4, 2023
1a80e8f
Update phpstan.neon
arderyp Mar 10, 2023
a7b25d8
Update src/ServerExtension.php
8000 arderyp Mar 10, 2023
4bca856
fixing phpstan ignore line issue
Mar 11, 2023
e508f0c
fixing CS issue
Mar 11, 2023
48de639
adding new GitHub Actions workflow for testing the suite with php 8.1…
Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
thought I removed new isGetClientStaticMethodAvailable function but I… 
… guess I didn't, removing now at @dunglas request
  • Loading branch information
Philip Ardery committed Mar 4, 2023
commit bf31fda6265f7d035f30d9f8538370a39d77bbad
11 changes: 4 additions & 7 deletions src/PantherTestCaseTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public function takeScreenshotIfTestFailed(): void
protected static function createPantherClient(array $options = [], array $kernelOptions = [], array $managerOptions = []): PantherClient
{
$browser = ($options['browser'] ?? self::$defaultOptions['browser'] ?? PantherTestCase::CHROME);
$callGetClient = self::isGetClientStaticMethodAvailable();
$callGetClient = method_exists(self::class, 'getClient') && (new \ReflectionMethod(self::class, 'getClient'))->isStatic();
if (null !== self::$pantherClient) {
$browserManager = self::$pantherClient->getBrowserManager();
if (
Expand Down Expand Up @@ -231,7 +231,9 @@ protected static function createHttpBrowserClient(array $options = [], array $ke
self::$httpBrowserClient->setServerParameter('HTTPS', 'true');
}

return self::isGetClientStaticMethodAvailable() ? self::getClient(self::$httpBrowserClient) : self::$httpBrowserClient; // @phpstan-ignore-line
// @phpstan-ignore-next-line
return method_exists(self::class, 'getClient') && (new \ReflectionMethod(self::class, 'getClient'))->isStatic() ?
self::getClient(self::$httpBrowserClient) : self::$httpBrowserClient;
}

private static function getWebServerDir(array $options): string
Expand All @@ -254,9 +256,4 @@ private static function getWebServerDir(array $options): string

return $_SERVER['PANTHER_WEB_SERVER_DIR'];
}

private static function isGetClientStaticMethodAvailable(): bool
{
return method_exists(self::class, 'getClient') && (new \ReflectionMethod(self::class, 'getClient'))->isStatic();
}
}
0