Add container.preload tag on all handlers #350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this sentence made me realize this might be a better option to fix the issue: If you agree, this means we could save us from merging this PR in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConsoleHandleris an event subscriber and therefore gets thecontainer.no_preloadtag automatically. However, we want to preload this class because it is in the hot path. So we have to add thecontainer.preloadtag to it (see symfony/symfony#36742).Instead of just adding the tag for this handler, it's better to add it for all (automatically) because all handlers are always pushed to a logger.