10BC0 Add mercure.publisher tag to publisher services by mtarld · Pull Request #36 · symfony/mercure-bundle · GitHub
[go: up one dir, main page]
Skip to content

Add mercure.publisher tag to publisher services #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

Add mercure.publisher tag to publisher services #36

merged 1 commit into from
Dec 8, 2020

Conversation

@mtarld
Copy link
Contributor
@mtarld mtarld commented Dec 8, 2020

In order to implement symfony/symfony#39342, we need to discover every publisher available in the service container.

Therefore, this PR simply add a mercure.publisher tag on each publisher service.

@mtarld mtarld mentioned this pull request Dec 8, 2020
Merged
dunglas
dunglas reviewed Dec 8, 2020
View reviewed changes
@mtarld mtarld force-pushed the feature/tag-pusblishers branch from 2aa079b to 01f8182 Compare December 8, 2020 20:37
@dunglas dunglas merged commit e873c90 into symfony:main Dec 8, 2020
@dunglas
Copy link
Member
dunglas commented Dec 8, 2020

Thanks @mtarld!

@mtarld mtarld deleted the feature/tag-pusblishers branch December 9, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtarld @dunglas
0