[WIP] adding DisableAutoMapping code to registration form #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aliases for use statements
|
This should be more-or-less done, but it's blocked by symfony/symfony#34694 and I also opened symfony/symfony#34860 |
|
Can't this one be merged now? |
|
I think this isn't "really" needed, as the auto-validation is "opt in" and I think most people are not enabling it globally anyways. |
|
We cannot enable it by default in the recipe because this PR isn't merge. Everything else is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If/when we merge the auto-validation recipe, the
make:registration-formshould disable validation on thepasswordfield. We could/should also try to add the annotation inmake:user(but it's only possible if you already have the validator installed).