Fix test suite : missing dependency symfony/translation for auth tests #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c3fa7f to
d903ffe
Compare
|
Thanks for the PR @adrienlucas. Indeed, this is a tricky one :). After checking into it, I think the bug isn't that we/users now need to install an extra dependency, but that there was a bug in Symfony itself. This was fixed at symfony/symfony#31988 - but it's not been released yet. To help catch these things faster in the future... and to prove that our tests WILL pass once that is tagged, I've made Travis (in #421) run our test suite against the next, unrelased patch version of Symfony (stable-dev) and the next unreleased minor version (dev). These tests are now passing on stable-dev (which, right now means that it's testing Symfony's 4.3 branch). Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a change merged in the
symfony/twig-bridge13 days ago, the test-suite is KO (see symfony/twig-bridge@52aa764).This solve the issue, let me know if there is a better way of doing so.