8000 Warn if using a maker non-interactively by kbond · Pull Request #1688 · symfony/maker-bundle · GitHub
[go: up one dir, main page]
Skip to content

Warn if using a maker non-interactively #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Warn if using a maker non-interactively #1688

merged 1 commit into from
Apr 25, 2025

Conversation

kbond
Copy link
Member
@kbond kbond commented Apr 25, 2025

Maker's are not meant to be run non-interactively. It's possible (?) some may support this so I opted for a warning instead of an exception.

Closes #1678

@kbond kbond force-pushed the make-controller-no-interaction branch from ccc8e69 to 2ba853e Compare April 25, 2025 17:22
bocharsky-bw
bocharsky-bw approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kbond kbond merged commit fd1764a into symfony:1.x Apr 25, 2025
7 checks passed
@kbond kbond deleted the make-controller-no-interaction branch April 25, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not run make:controller Foobar --no-interaction
3 participants
@kbond @weaverryan @bocharsky-bw
0