8000 [make:entity] managing keyword prefixes (is, has) for boolean properties getters by ClemRiviere · Pull Request #1493 · symfony/maker-bundle · GitHub
[go: up one dir, main page]
Skip to content

[make:entity] managing keyword prefixes (is, has) for boolean properties getters #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 27, 2024
Merged

[make:entity] managing keyword prefixes (is, has) for boolean properties getters #1493

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23dd534
Refactor addGetter prefix definition for boolean properties
ClemRiviere Mar 26, 2024
a5f5444
Adding unit tests concerning boolean properties getter prefixes
ClemRiviere Mar 26, 2024
7f539a2
Refactor getterName definition
ClemRiviere Mar 27, 2024
536c4e0
Fixing str compare & php-cs-fixer
ClemRiviere Mar 27, 2024
265e323
Fixing php-cs-fixer
ClemRiviere Mar 27, 2024
16082aa
Fixing getGetterName return type (always string)
ClemRiviere Mar 27, 2024
0281cd9
Enhancing getGetterName signature
ClemRiviere Mar 27, 2024
af7a161
Managing 'is' keyword for boolean properties setter
ClemRiviere Mar 27, 2024
c038153
Fixing php-cs-fixer
ClemRiviere Mar 27, 2024
85dfab0
Fixing setIsVerified > setVerified EmailVerifier
ClemRiviere Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhancing getGetterName signature
  • Loading branch information
@ClemRiviere
ClemRiviere committed Mar 27, 2024
commit 0281cd90ac2261bf706f7ca7d8cd6b9f8d3cd7ce
4 changes: 2 additions & 2 deletions src/Util/ClassSourceManipulator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ public function addGetter(string $propertyName, $returnType, bool $isReturnTypeN
$methodName = $this->getGetterName($propertyName, $returnType);
$this->addCustomGetter($propertyName, $methodName, $returnType, $isReturnTypeNullable, $commentLines);
}
private function getGetterName($propertyName, $returnType): string

private function getGetterName(string $propertyName, $returnType): string
{
if ('bool' !== $returnType) {
return 'get'.Str::asCamelCase($propertyName);
Expand Down
0