feature #36426 [Form] Deprecated unused old ServerParams util (HeahDude)

fabpot · fabpot · commit bf4b3a8d5933 · 2020-04-12T15:57:46.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Form] Deprecated unused old `ServerParams` util | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | ~ | License | MIT | Doc PR | ~ A left over after symfony/symfony#11924 (comment), this class is unused since Symfony 2.3 ^^'. I've noticed it before but never took the time to submit a PR because this is very minor IMHO. But since this deprecation should not impact anyone, let's keep the codebase clean and remove it in 6.0. Commits ------- e05e924c5a [Form] Deprecated unused old `ServerParams` util
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ CHANGELOG
  * Implementing the `FormConfigBuilderInterface` without implementing the `setIsEmptyCallback()` method
    is deprecated. The method will be added to the interface in 6.0.
  * Added a `rounding_mode` option for the PercentType and correctly round the value when submitted
+ * Deprecated `Symfony\Component\Form\Extension\Validator\Util\ServerParams` in favor of its parent class `Symfony\Component\Form\Util\ServerParams`
 
 5.0.0
 -----
diff --git a/Extension/Validator/Util/ServerParams.php b/Extension/Validator/Util/ServerParams.php
@@ -13,8 +13,12 @@
 
 use Symfony\Component\Form\Util\ServerParams as BaseServerParams;
 
+trigger_deprecation('symfony/form', '5.1', 'The "%s" class is deprecated. Use "%s" instead.', ServerParams::class, BaseServerParams::class);
+
 /**
  * @author Bernhard Schussek <bschussek@gmail.com>
+ *
+ * @deprecated since Symfony 5.1. Use {@see BaseServerParams} instead.
  */
 class ServerParams extends BaseServerParams
 {
diff --git a/Tests/Extension/Validator/Util/LegacyServerParamsTest.php b/Tests/Extension/Validator/Util/LegacyServerParamsTest.php
@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Form\Tests\Extension\Validator\Util;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
+use Symfony\Component\Form\Extension\Validator\Util\ServerParams;
+
+class LegacyServerParamsTest extends TestCase
+{
+    use ExpectDeprecationTrait;
+
+    /**
+     * @group legacy
+     */
+    public function testClassIsDeprecated()
+    {
+        $this->expectDeprecation('Since symfony/form 5.1: The "Symfony\Component\Form\Extension\Validator\Util\ServerParams" class is deprecated. Use "Symfony\Component\Form\Util\ServerParams" instead.');
+
+        new ServerParams();
+    }
+}
diff --git a/Tests/Util/ServerParamsTest.php b/Tests/Util/ServerParamsTest.php
@@ -9,10 +9,10 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\Form\Tests\Extension\Validator\Util;
+namespace Symfony\Component\Form\Tests\Util;
 
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Form\Extension\Validator\Util\ServerParams;
+use Symfony\Component\Form\Util\ServerParams;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
 
