Merge branch '5.0'

nicolas-grekas · nicolas-grekas · commit d8c7e12204bd · 2020-04-12T11:49:11.000+02:00
* 5.0:
  [travis] fix CI (ter)
  Revert "[travis][appveyor] don't cache .phpunit"
  silence E_NOTICE triggered since PHP 7.4
  [Form] Removed legacy check in `ValidationListener`
  [HttpClient] fix HTTP/2 support on non-SSL connections - CurlHttpClient only
  Force ping after transport Exception
  do not merge constraints within interfaces
  [Validator] Fixed default group for nested composite constraints
diff --git a/Extension/Validator/EventListener/ValidationListener.php b/Extension/Validator/EventListener/ValidationListener.php
@@ -50,8 +50,7 @@ public function validateForm(FormEvent $event)
             foreach ($this->validator->validate($form) as $violation) {
                 // Allow the "invalid" constraint to be put onto
                 // non-synchronized forms
-                // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)
-                $allowNonSynchronized = (null === $violation->getConstraint() || $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
+                $allowNonSynchronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
 
                 $this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);
             }

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,7 @@ public function validateForm(FormEvent $event)`
`50`	`50`	`foreach ($this->validator->validate($form) as $violation) {`
`51`	`51`	`// Allow the "invalid" constraint to be put onto`
`52`	`52`	`// non-synchronized forms`
`53`		`- // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)`
`54`		`- $allowNonSynchronized = (null === $violation->getConstraint() \|\| $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
	`53`	`+ $allowNonSynch 48C8 ronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
`55`	`54`
`56`	`55`	`$this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);`
`57`	`56`	`}`