10000 added header values in the cache by fabpot · Pull Request #49 · symfony/flex · GitHub
[go: up one dir, main page]

Skip to content

added header values in the cache #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2017
Merged

added header values in the cache #49

merged 1 commit into from
Apr 11, 2017

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Apr 11, 2017

No description provided.

@fabpot fabpot merged commit 69dd07c into master Apr 11, 2017
fabpot added a commit that referenced this pull request Apr 11, 2017
This PR was merged into the 1.0-dev branch.

Discussion
----------

added header values in the cache

Commits
-------

69dd07c added header values in the cache
@fabpot fabpot deleted the headers branch April 11, 2017 18:24
tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
…stok)

This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] improve Makefile serve target

Related to symfony#49, I don't know if this the best way to do it. But as the Makefile is composed I don't think it's possible to use advanced Makefile features 😟

@greg0ire suggested something like this:

```makefile
.PHONY: serve

CONSOLE=bin/console

$(CONSOLE):
    @echo 'Woops! The console does not exist'
    @EXIT

serve: bin/console
    bin/console list server|grep server:start
    bin/console server:start
```

But don't know if you can have multiple targets with the same name but different conditions?

Commits
-------

7a7de4b [FrameworkBundle] improve Makefile serve target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0