Default lifetime issue #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they are failing.
… in FilesystemAdapter, ArrayAdapter and ApcuAdapter; It is suposed all adapter which inherits from AbstractAdapter is fixed.
|
Good catch @ecanovas! |
|
Thanks. Take note for your recommendations but it's been my first time doing something with github, tests in software, PRs, etc... And symfony/symfony repo seemed too big for a newbie. |
|
don't worry, the community is welcoming :) |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jul 28, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Cache] Fix default lifetime being ignored | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/cache#1 | License | MIT | Doc PR | - Courtesy of @ecanovas Commits ------- 35ba478 [Cache] Fix default lifetime being ignored
symfony-splitter
pushed a commit
that referenced
this pull request
Jul 28, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Cache] Fix default lifetime being ignored | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #1 | License | MIT | Doc PR | - Courtesy of @ecanovas Commits ------- 35ba478 [Cache] Fix default lifetime being ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cache component] DefaultLifetime for FilesystemAdapter, ApcuAdapter and ArrayAdapter wasn't working properly.
When It's used one of the specified Adapters with a defaultLifetime != 0, cacheItem doesn't expire at anytime.
Tests have been added to check this and code to fix it.