8000 Evaluate Relationals when casting to bool by qthequartermasterman · Pull Request #354 · symengine/symengine.py · GitHub
[go: up one dir, main page]
Skip to content

Evaluate Relationals when casting to bool #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Evaluate Relationals when casting to bool #354

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a96e507
Override __bool__ in Relational, so that it returns whatever the bool…
qthequartermasterman Jun 4, 2021
290f916
Update test_eval.py
qthequartermasterman Jun 5, 2021
8709957
Improved speed of boolean evaluation.
qthequartermasterman Jun 7, 2021
4090967
Added tests for Equality
qthequartermasterman Jun 7, 2021
f81c74a
Added Tests for Unequality, Less than, and Greater Than.
qthequartermasterman Jun 7, 2021
afa4925
Fixed boolean evaluation for Less Than and Greater Than.
qthequartermasterman Jun 7, 2021
feaeca0
Include workaround for environments without sympy.
qthequartermasterman Jun 8, 2021
1d4d0e9
Fix tests so that they will accept a ValueError for hard relational e…
qthequartermasterman Jun 8, 2021
cf784eb
Eliminated all approximations in Relational boolean evaluation. Raise…
qthequartermasterman Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_eval.py 
Fixed incorrect evaluation test. To get rid of a sin(x)**2, we need to subtract sin(x)**2, not x**2.
  • Loading branch information
@qthequartermasterman
qthequartermasterman committed Jun 5, 2021
commit 290f916cd6836f5b798d0866b8877cabd2d8bbf3
2 changes: 1 addition & 1 deletion symengine/tests/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_eval_double2():
x = Symbol("x")
e = sin(x)**2 + sqrt(2)
raises(RuntimeError, lambda: e.n(real=True))
assert abs(e.n() - x**2 - 1.414) < 1e-3
assert abs(e.n() - sin(x)**2.0 - 1.414) < 1e-3

def test_n():
x = Symbol("x")
Expand Down
0