8000 Using enum case instead of boolean value to indicate how SyntaxVisitor should continue. by nkcsgexi · Pull Request #35 · swiftlang/swift-syntax · GitHub
[go: up one dir, main page]
Skip to content

Using enum case instead of boolean value to indicate how SyntaxVisitor should continue. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2018
Merged

Using enum case instead of boolean value to indicate how SyntaxVisitor should continue. #35

merged 2 commits into from
Nov 14, 2018

Conversation

nkcsgexi
Copy link
Contributor

No description provided.

@nkcsgexi nkcsgexi requested review from akyrtzi and nathawes November 13, 2018 21:44
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

ahoppen
ahoppen approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member
@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkcsgexi
Copy link
Contributor Author

@ahoppen for some reason i cannot add you to the reviewers so I have to ping you specifically in the comment.

@ahoppen
Copy link
Member
ahoppen commented Nov 13, 2018

I think that might be because I‘m no longer in any Apple-affiliated groups on GitHub, not even the Open-Source contributors. @shahmishal could this be?

nathawes
nathawes approved these changes Nov 13, 2018
View reviewed changes
Copy link
@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nathawes nathawes mentioned this pull request Nov 14, 2018
Merged
@nkcsgexi nkcsgexi merged commit d62ad83 into swiftlang:master Nov 14, 2018
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
@allevato
Merge pull request swiftlang#35 from kitasuke/SR-11291
1db79c0 
[SR-11291] Missing space after semicolon in swift-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@ahoppen ahoppen ahoppen approved these changes

@nathawes nathawes nathawes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkcsgexi @ahoppen @akyrtzi @nathawes
0